This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Update default discovery and refresh config values #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this because mira is chatty? I'm just thinking around when in production if you'd rather not have the shorter values. |
| const defaultEngineDiscoveryRefreshRate = 1000; | ||
| const defaultEngineHealthRefreshRate = 5000; | ||
| const defaultEngineDiscoveryRefreshRate = 10000; | ||
| const defaultEngineHealthRefreshRate = 30000; |
There was a problem hiding this comment.
Is this not a bit too infrequent? I cannot tell what is right but every 30 s introduces quite some delay until an unhealthy engine is detected.
There was a problem hiding this comment.
Docker default healthcheck interval for Mira is 30 seconds so that is why I chose that value.
This value in Config.js is also used as the interval for Mira to fetch metrics from each engine. Atleast in my opinion 5 seconds is a bit greedy for both health and metrics, and if a shorter interval is needed it is still configurable using env variables.
peol
approved these changes
Nov 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mira has a very short interval for discovering and checking health on engines. Changed the interval to: